Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move continue button to below the pricing summary #2101

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

lailien3
Copy link
Contributor

https://eaflood.atlassian.net/browse/IWTF-4379
https://eaflood.atlassian.net/browse/IWTF-4380

Pricing summary appears beneath green button.

This means that if a user doesn't scroll down, they will miss them and may not know the licence price to make an informed decisions until further into the journey. This may result in a user clicking back and forth through the journey rather than proceeding smoothly through.

https://eaflood.atlassian.net/browse/IWTF-4379
https://eaflood.atlassian.net/browse/IWTF-4380

Pricing summary appears beneath green button.

This means that if a user doesn't scroll down, they will miss them and may not know the licence price to make an informed decisions until further into the journey. This may result in a user clicking back and forth through the journey rather than proceeding smoothly through.
@lailien3 lailien3 added the bug Something isn't working label Dec 23, 2024
@lailien3 lailien3 self-assigned this Dec 23, 2024
.govuk-grid-row {
position: relative;
padding-bottom: 75px;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These styles are fine, but they'll require far more testing effort than if you confined them to only the pages they're needed on - i.e. the licence type and licence length pages. To do this we can use the :has pseudo-class:

.govuk-grid-row:has(.payment-summary-wrap)

This will only target the #continue and .govuk-grid-row elements on pages where the payment summary exists, which is exactly what we want. The :has pseudo class is supported by mobile browsers released in 2022 and 2023, so well within Grade B support. Realistically, there will be those with old smartphones stuck on old versions of Android or iOS that don't offer support to this selector, but they'll regress gracefully to the version where the prices display beneath the continue button. We should check this with the PO after QA to see whether it's acceptable to do this.

.govuk-grid-row:has(.payment-summary-wrap) {
position: relative;
padding-bottom: 75px;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've misunderstood my last comment - the #continue button styles need to go inside a parent selector too, otherwise every single continue button will have the same style and so be absolutely positioned, which I don't think is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants